Cleanup handling of KAFKA_VERSION env var in tests #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
simplify-version-checking-using-pytest-skipif
branch
from
9756d51 to
778acbc
Compare
Now that we are using `pytest`, there is no need for a custom decorator because we can use `pytest.mark.skipif()`. This makes the code significantly simpler. In particular, dropping the custom `@kafka_versions()` decorator is necessary because it uses `func.wraps()` which doesn't play nice with `pytest` fixtures: - pytest-dev/pytest#677 - https://stackoverflow.com/a/19614807/770425 So this is a pre-requisite to migrating some of those tests to using pytest fixtures.
jeffwidman
force-pushed
the
simplify-version-checking-using-pytest-skipif
branch
from
778acbc to
bc87474
Compare
jeffwidman
commented
Aug 22, 2019
| from test.service import ExternalService, SpawnedService | ||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def random_string(length): | ||
| return "".join(random.choice(string.ascii_letters) for i in range(length)) |
There was a problem hiding this comment.
I had to move this out of this file, at least for now, to solve a circular import problem. That wasn't present in the original version of working on this, likely because I'd already deleted a ton of code related to Simple* code paths... so it can be moved back later if semantically better here. But for now simplest to move it out to solve the import problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are using
pytest, there is no need for a custom decoratorbecause we can use
pytest.mark.skipif().This makes the code significantly simpler. In particular, dropping the
custom
@kafka_versions()decorator is necessary because it usesfunc.wraps()which doesn't play nice withpytestfixtures:So this is a pre-requisite to migrating some of those tests to using
pytestfixtures.This change is